Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26414195AC for ; Tue, 12 Apr 2016 23:10:01 +0000 (UTC) Received: (qmail 49518 invoked by uid 500); 12 Apr 2016 23:10:01 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 49466 invoked by uid 500); 12 Apr 2016 23:10:01 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 49438 invoked by uid 99); 12 Apr 2016 23:10:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 23:10:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0EF2A2AFD70; Tue, 12 Apr 2016 23:09:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9171758148344720778==" MIME-Version: 1.0 Subject: Re: Review Request 46111: Introduce a Curator-based `SingletonService`. From: Zameer Manji To: Bill Farner , Zameer Manji Cc: Aurora , John Sirois Date: Tue, 12 Apr 2016 23:09:57 -0000 Message-ID: <20160412230957.21369.30634@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46111/ In-Reply-To: <20160412212125.29094.23682@reviews.apache.org> X-Sender: Zameer Manji X-ReviewBoard-ShipIt: 1 References: <20160412212125.29094.23682@reviews.apache.org> X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora --===============9171758148344720778== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128574 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On April 12, 2016, 2:21 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46111/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 2:21 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1468 > https://issues.apache.org/jira/browse/AURORA-1468 > > > Repository: aurora > > > Description > ------- > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java | 4 ++ > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java | 2 +- > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java | 191 +++++++++++++++++++++++++++++++++++++++++++++++++ > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java | 114 +++++++++++++++++++++++++++++ > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java | 108 +++++----------------------- > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 523 insertions(+), 90 deletions(-) > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 3561d07f65d11060e4a96c9df06af44107a73430 > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 0ab24faadcba60ff8e68b2036562e4d39a4ac874 > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java 559838984a519bdbbb9ed60a71cea726dcd5cb52 > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/46111/diff/ > > > Testing > ------- > > Locally green: `./gradlew -Pq build`. > > NB: The SingletonServiceImplTest has more coverage and code surrounding illegal state transitions - double advertisement, double leave, advertise after leave (enforcing single-use). I can add those sorts of checks and test for the checks, but thought I'd leave this 1st RB here to reduce clutter and follow-up if folks want those sorts of checks. > > > Thanks, > > John Sirois > > --===============9171758148344720778==--