Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 585AD19D50 for ; Mon, 11 Apr 2016 23:01:17 +0000 (UTC) Received: (qmail 8988 invoked by uid 500); 11 Apr 2016 23:01:17 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 8931 invoked by uid 500); 11 Apr 2016 23:01:17 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 8906 invoked by uid 99); 11 Apr 2016 23:01:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 23:01:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A89FC2AF859; Mon, 11 Apr 2016 23:01:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6515496126774469928==" MIME-Version: 1.0 Subject: Re: Review Request 46057: Renaming ResourceType.getName() From: Zameer Manji To: Zameer Manji Cc: Aurora , Maxim Khutornenko Date: Mon, 11 Apr 2016 23:01:13 -0000 Message-ID: <20160411230113.21369.27967@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46057/ X-Sender: Zameer Manji X-ReviewBoard-ShipIt: 1 References: <20160411225623.29093.44577@reviews.apache.org> In-Reply-To: <20160411225623.29093.44577@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora --===============6515496126774469928== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46057/#review128279 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On April 11, 2016, 3:56 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46057/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 3:56 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Renaming getName() to getMesosName() to clearly state its meaning. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java dd9e12bdf9a11f357c9536dc5107e3fca35b3fb6 > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 78e7be93617da582afea8f22a5e9a9ba77d53e4b > src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 1d252bbbe0a1124a9ef8f13cf412e99984b2da1a > src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 6a5237f2151a4e9a8a551c1e3a2f72f899ad4df9 > src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java 43696d2fe044489f3daaeb9048282de52f939435 > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 5900ccb4d865db3cbd69e16b199e0123170d80f9 > src/main/java/org/apache/aurora/scheduler/resources/Resources.java 46b31f0315df6fdb6a02f3c9f54591030843d6f9 > src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 48a665f960dc202136af1f1cb6c37a0697b9563b > src/test/java/org/apache/aurora/scheduler/mesos/Offers.java a7fb4b014815d36fc254d0051cb5561e3f6d0039 > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 073987759e7d7481bb74cb32f2dd47a3d38a6f2a > src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 319ffea017529c03f19a723d99e9eb971660a576 > src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java 8d5a143a0e8b57a1515defa92cce4d68f1d47963 > src/test/java/org/apache/aurora/scheduler/resources/ResourcesTest.java bc2700c1b876dfee4df038b769dc6a39e4699117 > src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java c23efed552c122657352f2b79192f302034a6221 > > Diff: https://reviews.apache.org/r/46057/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > > --===============6515496126774469928==--