Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72A0719760 for ; Mon, 11 Apr 2016 21:24:55 +0000 (UTC) Received: (qmail 10321 invoked by uid 500); 11 Apr 2016 21:24:55 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10266 invoked by uid 500); 11 Apr 2016 21:24:55 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 10244 invoked by uid 99); 11 Apr 2016 21:24:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 21:24:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CCCBF2AF6DD; Mon, 11 Apr 2016 21:24:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8136161927652884116==" MIME-Version: 1.0 Subject: Re: Review Request 46051: Moving resource-related classes into a new package From: Zameer Manji To: Zameer Manji Cc: Aurora , Maxim Khutornenko Date: Mon, 11 Apr 2016 21:24:51 -0000 Message-ID: <20160411212451.21369.49229@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46051/ In-Reply-To: <20160411212311.29093.52539@reviews.apache.org> X-Sender: Zameer Manji X-ReviewBoard-ShipIt: 1 References: <20160411212311.29093.52539@reviews.apache.org> X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/ResourceSlot.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/AcceptedOfferTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/resources/Resources.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/resources/ResourcesTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/resources/ResourceAggregates.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/ResourceType.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/Resources.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/ResourcesTest.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora --===============8136161927652884116== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46051/#review128257 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On April 11, 2016, 2:23 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46051/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:23 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > IDE-driven refactoring. No functional changes. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/Offers.java 4c232f6b5a223b7da484a16e21cadad4fc155e35 > src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java 9c2dc0ba54bffa8b36d5bf5fe2f549934470087c > src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d > src/main/java/org/apache/aurora/scheduler/ResourceType.java b4efc8d5b3e85f7bee792ae994480cf09cfe7e31 > src/main/java/org/apache/aurora/scheduler/Resources.java 4baf9dddb1d846b37f3ff6362ec15606a9de0259 > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 1fe27a55acdf1fe89a8d9cff97ff261c2dd32e3a > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java e4279b16e4e5f5ad80604c38a0b68e3d0e3138eb > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e8eb0cabb47cdfab30d63d643be0b929b93a8c0 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java e9ee049e51e72fcf670ff74db6c3a9f83ab5622d > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java fb7c7b202c3002a6be4165628ee419a104870ac9 > src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 8cef410e39fd1e4a60c991dbf4bd122e95acde58 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 7d92843504ef3cf17db7c780fc488451600cd6ba > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java d3b79635ece02d630bbdb1b53c25c94c2fb9978d > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java c18836a33341d56569763d6bfe3213e49110a26d > src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java bf7c0840dceb2fe586692158dee4114d4def9c83 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0c467a65798c86efd9d0b60e5a53c5d5289fb54d > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 08eb6d6c722950f6bc75c97ce12380eca16e704d > src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java c9e57ececc5981c92248fd9974cf31dd71dd33e1 > src/test/java/org/apache/aurora/scheduler/AcceptedOfferTest.java 49ced129f49e741dedfbf33aa334a7cd3f09d732 > src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 6564e82a1431a5194241389c63240ec3f4c4d275 > src/test/java/org/apache/aurora/scheduler/ResourcesTest.java ea74842fb976fd0542d136316b77be1206b4a5f0 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java b1426bc43d728f6aeaa8440ceaf4eec913cdc1d2 > src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java ea876887f02472cc7b52e6c79ab3297d872b932f > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java b9f9f529d2ea765e89dd751057228631359a66e1 > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 17101f101f2ec1e9be75622ad31c760f46edd8c8 > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 4f5ac1519a3121cf59ea055adf00d5239951b769 > src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 13f41e3fcd9919c1827b51eb51e9e3271c337b43 > src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 155ece448741e2ec0844e8651a5bee17a1f22697 > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java bb1b01e15b95621637171331e0c72aebb9d77425 > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java aedeab3fb89ca88df5f37e14bbcf0a109dfecbe7 > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 0698f78de65d394597f33addb6651c48cf227b94 > src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java f6bbbb81c15e917a54f084cf62787d85fc14e547 > src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 6af1fffceb5cdc7406a67d608e4a01ebdf71a2d0 > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java b5fd204081ee802768d4926973689b22e94c1ed2 > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java c3240cd457fb6bffe6077a3ded17afea4c9f6234 > > Diff: https://reviews.apache.org/r/46051/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > > --===============8136161927652884116==--