Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 737D018353 for ; Wed, 6 Apr 2016 23:19:54 +0000 (UTC) Received: (qmail 8564 invoked by uid 500); 6 Apr 2016 23:19:54 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 8510 invoked by uid 500); 6 Apr 2016 23:19:54 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 8487 invoked by uid 99); 6 Apr 2016 23:19:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 23:19:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7755B2ACCFF; Wed, 6 Apr 2016 23:19:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4579277379393602162==" MIME-Version: 1.0 Subject: Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics. From: Aurora ReviewBot To: Bill Farner , Maxim Khutornenko Cc: Aurora ReviewBot , Zameer Manji , Aurora Date: Wed, 06 Apr 2016 23:19:51 -0000 Message-ID: <20160406231951.26225.58469@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45821/ X-Sender: Aurora ReviewBot References: <20160406223520.20106.90409@reviews.apache.org> In-Reply-To: <20160406223520.20106.90409@reviews.apache.org> X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImpl.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImplTest.java Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============4579277379393602162== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45821/#review127504 ----------------------------------------------------------- Master (103dae6) is red with this patch. ./build-support/jenkins/build.sh  self._clock.converge(threads=[hct.threaded_health_checker])  self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs  assert hct._total_latency == 0.5  assert hct.metrics.sample()['total_latency_secs'] == 0.5  assert hct.metrics.sample()['checks'] == 1    # tick again  self._clock.tick(1.0 + epsilon)  self._clock.converge(threads=[hct.threaded_health_checker])  self._clock.tick(0.5 + epsilon)  self._clock.converge(threads=[hct.threaded_health_checker])  self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs > assert hct._total_latency == 1.0 E AssertionError: assert 1.001 == 1.0 E + where 1.001 = ._total_latency src/test/python/apache/aurora/executor/common/test_health_checker.py:184: AssertionError -------------- Captured stderr call -------------- [] Time now: 0.0 [] Time now: 0.0 [] Time now: 1.0 [] Time now: 1.001 [] Time now: 1.001 [] Time now: 1.501 [] Time now: 1.502 [] Time now: 1.502 [] Time now: 2.502 [] Time now: 2.503 [] Time now: 2.503 [] Time now: 3.003 [] Time now: 3.004 generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml  1 failed, 664 passed, 5 skipped, 1 warnings in 313.91 seconds  FAILURE  Waiting for background workers to finish. 23:19:52 07:56 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 6, 2016, 10:35 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45821/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 10:35 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > ------- > > This swaps out our use of the mybatis default cache with a custom one backed by Guava. The benefit of this is that we can now plumb cache statistics out which is helpful in debugging performance problems with MyBatis. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImpl.java PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 41519dee391a37ff4904b6c52dc276d278b85f1f > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml fd272ccf9b1cfccd9198d1e5e0db37d23f546afa > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 0219bf3da01936824154675ac812bc53cb308d3f > src/test/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImplTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/45821/diff/ > > > Testing > ------- > > Saw metrics in vagrant environment. > > > Thanks, > > Zameer Manji > > --===============4579277379393602162==--