Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 99228180C4 for ; Wed, 6 Apr 2016 22:28:01 +0000 (UTC) Received: (qmail 29069 invoked by uid 500); 6 Apr 2016 22:28:01 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 29009 invoked by uid 500); 6 Apr 2016 22:28:01 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 28982 invoked by uid 99); 6 Apr 2016 22:28:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 22:28:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1530E2ACCE9; Wed, 6 Apr 2016 22:27:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0616694391370016865==" MIME-Version: 1.0 Subject: Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC. From: Bill Farner To: Maxim Khutornenko , Zameer Manji Cc: Bill Farner , Aurora ReviewBot , Stephan Erb , Aurora Date: Wed, 06 Apr 2016 22:27:58 -0000 Message-ID: <20160406222758.20107.41724@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45725/ X-Sender: Bill Farner References: <20160406190548.20106.22831@reviews.apache.org> In-Reply-To: <20160406190548.20106.22831@reviews.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============0616694391370016865== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ ----------------------------------------------------------- (Updated April 6, 2016, 3:27 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes ------- re-rebase Bugs: AURORA-1595 https://issues.apache.org/jira/browse/AURORA-1595 Repository: aurora Description ------- Remove AddInstancesConfig parameter from addInstances RPC. Diffs (updated) ----- RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1 src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54 src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69 Diff: https://reviews.apache.org/r/45725/diff/ Testing ------- end-to-end tests are green Thanks, Bill Farner --===============0616694391370016865==--