Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 22E3B19760 for ; Wed, 6 Apr 2016 19:41:21 +0000 (UTC) Received: (qmail 20223 invoked by uid 500); 6 Apr 2016 19:41:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 20165 invoked by uid 500); 6 Apr 2016 19:41:21 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 20146 invoked by uid 99); 6 Apr 2016 19:41:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 19:41:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DBF632ACC50; Wed, 6 Apr 2016 19:41:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1672665344264643005==" MIME-Version: 1.0 Subject: Review Request 45829: Lift the standard `ServerSet` encoding. From: John Sirois To: Bill Farner Cc: Aurora , John Sirois Date: Wed, 06 Apr 2016 19:41:17 -0000 Message-ID: <20160406194117.26225.52766@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45829/ X-Sender: John Sirois X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetTest.java Reply-To: John Sirois X-ReviewRequest-Repository: aurora --===============1672665344264643005== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45829/ ----------------------------------------------------------- Review request for Aurora and Bill Farner. Bugs: AURORA-1468 https://issues.apache.org/jira/browse/AURORA-1468 Repository: aurora Description ------- This exposes the standard `ServerSet` `ServiceInstance` encoding to the `ServerSet` interface for conforming implementations to leverage. commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java | 90 +++++++++++++++++++++++++++++++++++++++ commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java | 114 +------------------------------------------------- commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java | 49 ---------------------- commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetTest.java | 78 ++++++++++++++++++++++++++++++++++ commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java | 7 +--- 5 files changed, 172 insertions(+), 166 deletions(-) Diffs ----- commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 6e3208384149d34a6a1f0de86e8346be227efe69 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 8b385b8ed07a109ee357d092f8919582035dc7cb commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 37be70b7066d5a57f342e1f77d8269533d715406 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetTest.java PRE-CREATION commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 85b89d560fb3a01f0dd9eea6e0ce521c7adbc247 Diff: https://reviews.apache.org/r/45829/diff/ Testing ------- Locally green: ``` ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois --===============1672665344264643005==--