Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 145381924F for ; Wed, 6 Apr 2016 18:06:35 +0000 (UTC) Received: (qmail 91434 invoked by uid 500); 6 Apr 2016 18:06:34 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 91378 invoked by uid 500); 6 Apr 2016 18:06:34 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 91278 invoked by uid 99); 6 Apr 2016 18:06:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 18:06:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7704C2ACB94; Wed, 6 Apr 2016 18:06:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2880628093691418100==" MIME-Version: 1.0 Subject: Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC. From: Bill Farner To: Maxim Khutornenko , Zameer Manji Cc: Bill Farner , Aurora ReviewBot , Stephan Erb , Aurora Date: Wed, 06 Apr 2016 18:06:31 -0000 Message-ID: <20160406180631.20107.39461@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45725/ X-Sender: Bill Farner References: <20160406174924.20106.98718@reviews.apache.org> In-Reply-To: <20160406174924.20106.98718@reviews.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============2880628093691418100== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/ ----------------------------------------------------------- (Updated April 6, 2016, 11:06 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes ------- git-add file missed in rebase Bugs: AURORA-1595 https://issues.apache.org/jira/browse/AURORA-1595 Repository: aurora Description ------- Remove AddInstancesConfig parameter from addInstances RPC. Diffs (updated) ----- RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028 src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71 Diff: https://reviews.apache.org/r/45725/diff/ Testing ------- end-to-end tests are green Thanks, Bill Farner --===============2880628093691418100==--