Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4201219C9F for ; Wed, 6 Apr 2016 16:05:40 +0000 (UTC) Received: (qmail 5485 invoked by uid 500); 6 Apr 2016 16:05:40 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 5431 invoked by uid 500); 6 Apr 2016 16:05:40 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 5410 invoked by uid 99); 6 Apr 2016 16:05:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 16:05:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D2BC2ACADE; Wed, 6 Apr 2016 16:05:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4296760910117185079==" MIME-Version: 1.0 Subject: Re: Review Request 45779: Small Documentation fixes and nitpicks. From: Aurora ReviewBot To: Bill Farner , Stephan Erb Cc: Aurora ReviewBot , Aurora , Tony Dong Date: Wed, 06 Apr 2016 16:05:37 -0000 Message-ID: <20160406160537.20106.13865@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45779/ X-Sender: Aurora ReviewBot References: <20160406153731.20106.28715@reviews.apache.org> In-Reply-To: <20160406153731.20106.28715@reviews.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============4296760910117185079== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127352 ----------------------------------------------------------- Master (b2df0eb) is red with this patch. ./build-support/jenkins/build.sh  self._clock.converge(threads=[hct.threaded_health_checker])  self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs  assert hct._total_latency == 0.5  assert hct.metrics.sample()['total_latency_secs'] == 0.5  assert hct.metrics.sample()['checks'] == 1    # tick again  self._clock.tick(1.0 + epsilon)  self._clock.converge(threads=[hct.threaded_health_checker])  self._clock.tick(0.5 + epsilon)  self._clock.converge(threads=[hct.threaded_health_checker])  self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs > assert hct._total_latency == 1.0 E AssertionError: assert 1.001 == 1.0 E + where 1.001 = ._total_latency src/test/python/apache/aurora/executor/common/test_health_checker.py:184: AssertionError -------------- Captured stderr call -------------- [] Time now: 0.0 [] Time now: 0.0 [] Time now: 1.0 [] Time now: 1.001 [] Time now: 1.001 [] Time now: 1.501 [] Time now: 1.502 [] Time now: 1.502 [] Time now: 2.502 [] Time now: 2.503 [] Time now: 2.503 [] Time now: 3.003 [] Time now: 3.004 generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml  1 failed, 664 passed, 5 skipped, 1 warnings in 271.62 seconds  FAILURE  Waiting for background workers to finish. 16:05:37 06:16 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 6, 2016, 3:37 p.m., Tony Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45779/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 3:37 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Small Documentation fixes and nitpicks. > > > Diffs > ----- > > docs/additional-resources/tools.md 354ccf07b5d457aff387cfa7cc775fea79b3a387 > docs/development/client.md 7d0c2309983cb2151af2022997f0f7432f4d2d3d > docs/development/committers-guide.md 309a6522ec9e8750c7b13e211eca7517b358a05f > docs/development/scheduler.md a26dfadf2963538c91c04224540312e01c7f70ae > docs/features/services.md 691fa28ad3e9476e4137bc23dbcda58f5e377387 > docs/getting-started/overview.md 854f8d7109a1c7d94dfa960f169d796faba95f87 > > Diff: https://reviews.apache.org/r/45779/diff/ > > > Testing > ------- > > > Thanks, > > Tony Dong > > --===============4296760910117185079==--