Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C39019628 for ; Tue, 5 Apr 2016 23:00:13 +0000 (UTC) Received: (qmail 28938 invoked by uid 500); 5 Apr 2016 23:00:13 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 28888 invoked by uid 500); 5 Apr 2016 23:00:13 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 28782 invoked by uid 99); 5 Apr 2016 23:00:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 23:00:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 708F42AC9E0; Tue, 5 Apr 2016 23:00:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1007327280679387193==" MIME-Version: 1.0 Subject: Re: Review Request 45177: Setting DiscoveryInfo. From: Zhitao Li To: Stephan Erb , Kunal Thakar Cc: Zhitao Li , Aurora , Maxim Khutornenko , Joshua Cohen , Aurora ReviewBot Date: Tue, 05 Apr 2016 23:00:10 -0000 Message-ID: <20160405230010.20107.8830@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zhitao Li X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45177/ X-Sender: Zhitao Li References: <20160405181542.20107.45312@reviews.apache.org> In-Reply-To: <20160405181542.20107.45312@reviews.apache.org> Reply-To: Zhitao Li X-ReviewRequest-Repository: aurora --===============1007327280679387193== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ ----------------------------------------------------------- (Updated April 5, 2016, 11 p.m.) Review request for Aurora, Kunal Thakar and Stephan Erb. Changes ------- Adding an end to end test using `jq` to parse `/state` endpoint of master, and check the following: - discovery info is not empty; - name is correct; - number of ports are not zero. (Another patch of installing 'jq' in packer will be sent soon) Bugs: AURORA-1629 https://issues.apache.org/jira/browse/AURORA-1629 Repository: aurora Description ------- This allows alternative service discovery methodologies to find tasks from Aurora (e.g. mesos-dns), especially the dynamic port mapping. Diffs (updated) ----- RELEASE-NOTES.md 2f935da01201cbef095e9d308630e187914f00ff docs/features/service-discovery.md 858ca2a137db9c8fbce20e9b2b924447fe7a41ae docs/reference/scheduler-configuration.md e6c0bb60281d7c39c2aa235445ee4c1ef97464ba examples/vagrant/upstart/aurora-scheduler.conf d61801c0b7c9683434a548a26bed3c49bbb75927 src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java add1270409b7e82578267a2c10cf2afe6e93e3de src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 7beea81a1e97f3f2fce215ff3e364919c3aebf6d src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 85c550bb5754154de5f639df4a0992d10cb70993 src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 7110fbd78b1b4356acd40e5ab9c3379e5ac19df7 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 3a6048633efceec68b15d3c511237c0f1871a3fc src/test/sh/org/apache/aurora/e2e/http/http_example.aurora bb4fdec2fb2347635c6a7cc9e13133b4bf407771 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 34717569365bbaad7117d7ec996e448462023fe8 Diff: https://reviews.apache.org/r/45177/diff/ Testing ------- 1. Added unit test; 2. Use the vagrant environment to start the example in http_example.aurora, and observe the following in master's state.json: ``` curl 192.168.33.7:5050/state | jq . | less .... "tasks": [ { "discovery": { "environment": "test", "location": "devcluster", "name": "http_example.test.vagrant", "ports": { "ports": [ { "name": "tcp", "number": 31499, "protocol": "TCP" }, { "name": "http", "number": 31529, "protocol": "TCP" } ] }, "visibility": "CLUSTER" }, "executor_id": "thermos-vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703", "framework_id": "66d5ac1b-9243-4ef3-8016-40f19d079f5d-0000", "id": "vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703", "name": "vagrant/test/http_example", "resources": { "cpus": 0.4, "disk": 64, "mem": 32, "ports": "[31499-31499, 31529-31529]" }, ... .... ``` Thanks, Zhitao Li --===============1007327280679387193==--