Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1970197FA for ; Tue, 5 Apr 2016 03:10:52 +0000 (UTC) Received: (qmail 26073 invoked by uid 500); 5 Apr 2016 03:10:52 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 26019 invoked by uid 500); 5 Apr 2016 03:10:52 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 25994 invoked by uid 99); 5 Apr 2016 03:10:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 03:10:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4E7612AA5E9; Tue, 5 Apr 2016 03:10:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7434294796145829439==" MIME-Version: 1.0 Subject: Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC. From: Aurora ReviewBot To: Maxim Khutornenko , Zameer Manji Cc: Bill Farner , Aurora ReviewBot , Aurora Date: Tue, 05 Apr 2016 03:10:49 -0000 Message-ID: <20160405031049.20107.72720@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45725/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20160405025317.20106.55214@reviews.apache.org> In-Reply-To: <20160405025317.20106.55214@reviews.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============7434294796145829439== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127018 ----------------------------------------------------------- Ship it! Master (f729fd4) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 5, 2016, 2:53 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45725/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 2:53 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1595 > https://issues.apache.org/jira/browse/AURORA-1595 > > > Repository: aurora > > > Description > ------- > > Remove AddInstancesConfig parameter from addInstances RPC. > > > Diffs > ----- > > RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf > api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2 > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467 > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd > src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f > src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103 > src/test/python/apache/aurora/client/api/test_api.py c066ae7a05fbabaf7800d12459a743772366cbaa > src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2 > > Diff: https://reviews.apache.org/r/45725/diff/ > > > Testing > ------- > > end-to-end tests are green > > > Thanks, > > Bill Farner > > --===============7434294796145829439==--