aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.
Date Fri, 29 Apr 2016 01:08:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46803/#review131025
-----------------------------------------------------------



Is there ever a case where we wouldn't want to show the tier? I.e., can someone configure
the scheduler to *not* use tiers, or are they always on now?

I'm concerned that this is fairly prominent UI placement for a concept that will be completely
unknown to users. It's hard for me to judge what the best UI is to represent tiers when no
one's actually using them yet (e.g. will users think in terms of tier names, or will they
think in terms of the properties associated with tiers, in which case, would it make more
sense to break it down to the level of preemptible and revocable).

I guess for now, given the unknowns this is fine and we can iterate as we get feedback from
users.

- Joshua Cohen


On April 28, 2016, 11:09 p.m., Amol Deshmukh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46803/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 11:09 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1458: Add tier into the UI "show config" summary.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/configSummary.html 1af7511de0e8a143c8ea88377aad756b44e3ac30

>   src/main/resources/scheduler/assets/js/controllers.js 84417ebeadfae57d55b9f12e8a985825bd620fc8

>   src/main/resources/scheduler/assets/js/services.js d9ce52065f9573b0aa68a95da7da7c50fb14310a

>   src/main/resources/scheduler/assets/schedulingDetail.html eb88c1e6dec7a26643e8b13ffcf8e90df70a67f7

> 
> Diff: https://reviews.apache.org/r/46803/diff/
> 
> 
> Testing
> -------
> 
> Ensured the changes appear in the UI after launching the scheduler using vagrant.
> 
> 
> File Attachments
> ----------------
> 
> Jobs by Role
>   https://reviews.apache.org/media/uploaded/files/2016/04/28/7cbec002-e213-4c24-92d9-16b45efb839c__Jobs_by_Role.png
> Per Job Config Summary
>   https://reviews.apache.org/media/uploaded/files/2016/04/28/5b785fa7-1053-4b8b-ba0d-438a9170c756__Per_Job_Config_Summary.png
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message