aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 46596: Command line flag to change FrameworkInfo.name
Date Wed, 27 Apr 2016 22:16:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130857
-----------------------------------------------------------



Master (7e30ebe) is red with this patch.
  ./build-support/jenkins/build.sh

:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java:80:
error: Line is longer than 100 characters (found 107).
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 3 mins 16.989 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 27, 2016, 9:36 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 9:36 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
>     https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This commit introduces a new command line flag `-framework_name` and changes the value
from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as https://issues.apache.org/jira/browse/MESOS-2614 has
been fixed. The new value will be shown on the UI and used for Mesos DNS. I have skipped a
deprecation cycle for this change, as if an operator wants to maintain the old value, he can
simply use the new option when deploying the next Aurora version.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md d2262f79edfde23eccd87bae7f1cf319b63b1103

>   src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> -------
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message