aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <>
Subject Re: Review Request 46596: Command line flag to change
Date Wed, 27 Apr 2016 21:36:49 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 27, 2016, 11:36 p.m.)

Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Warn operators about the potentially risky framework name change.

Bugs: AURORA-945

Repository: aurora


This commit introduces a new command line flag `-framework_name` and changes the value from
the hardcoded 'TwitterScheduler' to 'aurora'.

This change is non-intrusive as has been
fixed. The new value will be shown on the UI and used for Mesos DNS. I have skipped a deprecation
cycle for this change, as if an operator wants to maintain the old value, he can simply use
the new option when deploying the next Aurora version.

Diffs (updated)
----- 4b810f2d808cbf0d91c753147d98d1e389106d22 
  docs/features/ f242730fc16103903167182372ff6903127d73f5 
  docs/reference/ d2262f79edfde23eccd87bae7f1cf319b63b1103 
  src/main/java/org/apache/aurora/scheduler/mesos/ 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0




* ./gradlew -Pq build
* Changed the framework name in vagrant. Aurora happily re-registered without a fallout.


Stephan Erb

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message