aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 46596: Command line flag to change FrameworkInfo.name
Date Sun, 24 Apr 2016 15:52:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/#review130307
-----------------------------------------------------------



Thanks for doing this, long overdue!

Just one ship block for me - make sure to warn people against shooting themselves in the foot.


RELEASE-NOTES.md (line 13)
<https://reviews.apache.org/r/46596/#comment194021>

    Seems prudent to include a warning about MESOS-703 here and in a doc.


- Bill Farner


On April 22, 2016, 5:38 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46596/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 5:38 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-945
>     https://issues.apache.org/jira/browse/AURORA-945
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This commit introduces a new command line flag `-framework_name` and changes the value
from the hardcoded 'TwitterScheduler' to 'aurora'.
> 
> This change is non-intrusive as https://issues.apache.org/jira/browse/MESOS-2614 has
been fixed. The new value will be shown on the UI and used for Mesos DNS. I have skipped a
deprecation cycle for this change, as if an operator wants to maintain the old value, he can
simply use the new option when deploying the next Aurora version.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 4b810f2d808cbf0d91c753147d98d1e389106d22 
>   docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
>   docs/reference/scheduler-configuration.md d2262f79edfde23eccd87bae7f1cf319b63b1103

>   src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
>   src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
dc964b8dac1b8e21e86ad331216c57fa11abeb6d 
> 
> Diff: https://reviews.apache.org/r/46596/diff/
> 
> 
> Testing
> -------
> 
> * ./gradlew -Pq build
> * Changed the framework name in vagrant. Aurora happily re-registered without a fallout.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message