aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 46346: Add @Timed annotations to cron stores.
Date Mon, 18 Apr 2016 21:48:40 GMT


> On April 18, 2016, 2:26 p.m., Stephan Erb wrote:
> > Wouldn't it make sense to have `cron` in the stats names somehow? Just from reading
`/vars` it will be difficult for operators to figure out that those are covering cron jobs.

Good catch, updating the metrics.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/#review129438
-----------------------------------------------------------


On April 18, 2016, 2:07 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46346/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 2:07 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1665
>     https://issues.apache.org/jira/browse/AURORA-1665
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Both cron stores don't have @Timed annoations. This adds them so operators can look at
the throughput of storage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa

> 
> Diff: https://reviews.apache.org/r/46346/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message