aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role
Date Fri, 15 Apr 2016 23:55:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46290/#review129218
-----------------------------------------------------------



This patch does not apply cleanly against master (81f52e4), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 15, 2016, 11:46 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46290/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 11:46 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1666
>     https://issues.apache.org/jira/browse/AURORA-1666
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> adding do-not-demote-health-check-to-role flag to not demote health check user:group
to role
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 601d2859c3ca51b30fd15de56f75bd5255a51805 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 40a0cd6396a78c591debf5e2be11363ecf496231

>   src/main/python/apache/aurora/executor/common/health_checker.py d8675beb8f16ebdd2d6946367784411fe84a5cfc

>   src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a

> 
> Diff: https://reviews.apache.org/r/46290/diff/
> 
> 
> Testing
> -------
> 
> - end to end tests
> - added unit tests
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message