aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 46111: Introduce a Curator-based `SingletonService`.
Date Tue, 12 Apr 2016 23:09:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46111/#review128574
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On April 12, 2016, 2:21 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46111/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 2:21 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java      
     |   4 ++
>  commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
|   2 +-
>  src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java   
      | 191 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java  
      | 114 +++++++++++++++++++++++++++++
>  src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
  | 108 +++++-----------------------
>  src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
     | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 523 insertions(+), 90 deletions(-)
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 3561d07f65d11060e4a96c9df06af44107a73430

>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
0ab24faadcba60ff8e68b2036562e4d39a4ac874 
>   src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
559838984a519bdbbb9ed60a71cea726dcd5cb52 
>   src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46111/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq build`.
> 
> NB: The SingletonServiceImplTest has more coverage and code surrounding illegal state
transitions - double advertisement, double leave, advertise after leave (enforcing single-use).
 I can add those sorts of checks and test for the checks, but thought I'd leave this 1st RB
here to reduce clutter and follow-up if folks want those sorts of checks.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message