aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 46045: Removing unused quota_check.py
Date Mon, 11 Apr 2016 20:00:42 GMT


> On April 11, 2016, 7:56 p.m., Aurora ReviewBot wrote:
> > Master (0dd096d) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                            with temporary_dir() as checkpoint_root:
> >                              te = AuroraExecutor(
> >                      >           runner_provider=make_provider(checkpoint_root),
> >                                  sandbox_provider=DefaultTestSandboxProvider())
> >                      
> >                      src/test/python/apache/aurora/executor/test_thermos_executor.py:580:

> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      src/test/python/apache/aurora/executor/test_thermos_executor.py:193:
in make_provider
> >                          pex_location=thermos_runner_path(),
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      
> >                      build = True
> >                      
> >                          def thermos_runner_path(build=True):
> >                            if not build:
> >                              return getattr(thermos_runner_path, 'value', None)
> >                          
> >                            if not hasattr(thermos_runner_path, 'value'):
> >                              pex_dir = safe_mkdtemp()
> >                      >       assert subprocess.call(["./pants", "--pants-distdir=%s"
% pex_dir, "binary",
> >                                "src/main/python/apache/thermos/runner:thermos_runner"])
== 0
> >                      E       assert 1 == 0
> >                      E        +  where 1 = <function call at 0x7fe041850938>(['./pants',
'--pants-distdir=/tmp/user/10021/tmpB56S8e', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
> >                      E        +    where <function call at 0x7fe041850938>
= subprocess.call
> >                      
> >                      src/test/python/apache/aurora/executor/test_thermos_executor.py:185:
AssertionError
> >                      -------------- Captured stderr call --------------
> >                      Traceback (most recent call last):
> >                        File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants",
line 7, in <module>
> >                          from pants.bin.pants_exe import main
> >                      ImportError: No module named pants.bin.pants_exe
> >                       generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

> >                       16 failed, 631 passed, 6 skipped, 1 warnings, 8 error
in 225.25 seconds 
> >                      
> > FAILURE
> > 
> > 
> >                Waiting for background workers to finish.
> > 19:56:01 05:28   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

@ReviewBot retry


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46045/#review128225
-----------------------------------------------------------


On April 11, 2016, 7:19 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46045/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 7:19 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This was used by the client updater, which is now defunct.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/quota_check.py a3252e571c34ef20438cfbbce6ceda2a50af0883

>   src/test/python/apache/aurora/client/api/test_quota_check.py 0b97334d3b5bf9bf2306248fbf7878be4c1a3995

> 
> Diff: https://reviews.apache.org/r/46045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message