aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 45992: Make `ServerSet.JSON_CODEC` robust to errors.
Date Mon, 11 Apr 2016 17:39:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45992/#review128174
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On April 10, 2016, 1:57 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45992/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 1:57 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Previously bad or partial input (deserialize), and errors writing output
> (serialize) could throw exceptions not matching the `Codec` contract.
> Factor the codec into its own top-level class to allow testing the
> serialization failure case and expand coverage to include bad inputs.
> 
>  build.gradle                                                                       
                |   2 +
>  commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java            
                | 139 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java            
                |  78 +---------------------------
>  commons/src/test/java/org/apache/aurora/common/zookeeper/{ServerSetTest.java => JsonCodecTest.java}
|  79 ++++++++++++++++++++++++++--
>  4 files changed, 218 insertions(+), 80 deletions(-)
> 
> 
> Diffs
> -----
> 
>   build.gradle fc61adfcbaf12c8ea45f71c7efe69d4fe39597c6 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java PRE-CREATION

>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 2d978c1e492caea562a093ee0e6630fd219f7a3b

>   commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetTest.java b48c1f1fe3070e42f6e1e86833791ce8da2bc317

> 
> Diff: https://reviews.apache.org/r/45992/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq build`.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message