aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45935: Remove support for canonical command line arg names.
Date Fri, 08 Apr 2016 18:32:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45935/#review127834
-----------------------------------------------------------



Master (5ecded7) is red with this patch.
  ./build-support/jenkins/build.sh

:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean UP-TO-DATE
:api:clean UP-TO-DATE
:buildSrc:clean UP-TO-DATE
:commons:clean UP-TO-DATE
:commons-args:clean UP-TO-DATE
:enforceVersion UP-TO-DATE
:api:generateThriftJava
make: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
sha256=$(curl -s --show-error https://archive.apache.org/dist/thrift/0.9.1/thrift-0.9.1.tar.gz
| tee thrift-0.9.1.tar.gz | 	openssl dgst -sha256 | cut -d' ' -f2) && \
	[ "${sha256}" = "ac175080c8cac567b0331e394f23ac306472c071628396db2850cb00c41b0017" ] &&
\
	tar zxvf thrift-0.9.1.tar.gz && \
	cd thrift-0.9.1 && \
	sha256=$(curl -s --show-error https://issues.apache.org/jira/secure/attachment/12632477/yylex.patch
| tee thrift.patch | 	openssl dgst -sha256 | cut -d' ' -f2) && \
	[ "${sha256}" = "70f20b4e5b2e004b8a0d075b80a52750bce5be02ed83efdc60adbc45ec386a6c" ] &&
\
	patch -p1 < thrift.patch && \
	./configure --disable-dependency-tracking --disable-shared --without-c_glib --without-cpp
--without-csharp --without-d --without-erlang --without-go --without-java --without-haskell
--without-perl --without-php --without-php_extension --without-pic --without-python --without-qt4
--without-ruby --without-tests && \
	make -j4
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw''
finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 44.544 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 8, 2016, 6:26 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45935/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 6:26 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This was an obscure feature that brings no value.  The args system had this to support
a mono-repo, where collisions of arg 'short names' was possible.
> 
> Removing this has the side-effect of making the scheduler's help text ever-so-slightly
less daunting.  I've also changed the formatting in help text to make it more apparent when
default values are present.  See `scheduler-configuration.md`.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 0ca6486f30d245b2ca1ca08f6a9ca71d29d4bd7b 
>   commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 908553ce2fdb16d0e69b458823deb7f165550b93

>   commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java ca309a2b3d44f94e9f91d0690f810fe7bc646aed

>   commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java 12714949f433ec6b5d7c2794c2f31d82773174e7

>   commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 48737d4a831ab62945e48e4b9540a18ca2e2abab

>   commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java a4d74ed9d9093939dbaf088ba2a8a632b2a7f1c5

>   commons/src/test/java/org/apache/aurora/common/args/OptionInfoTest.java 98d951912627bfbf49e75037bccc914a430a45f4

>   docs/reference/scheduler-configuration.md f08603ad09f625d2d4b644b3b044c050e964dd66

> 
> Diff: https://reviews.apache.org/r/45935/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message