aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.
Date Fri, 08 Apr 2016 18:22:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127832
-----------------------------------------------------------



@ReviewBot retry

- Joshua Cohen


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we
were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst
combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6

>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c

>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message