aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.
Date Fri, 08 Apr 2016 17:20:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45902/#review127817
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java (line
85)
<https://reviews.apache.org/r/45902/#comment191196>

    `groupCache` is always non-null



src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java (line
92)
<https://reviews.apache.org/r/45902/#comment191197>

    ditto



src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java (line
75)
<https://reviews.apache.org/r/45902/#comment191198>

    Varargs is a bit funny here - always used with exactly 1 arg.  If you keep varargs, it
would be nice to design the method signature to require at least one



src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java (line
76)
<https://reviews.apache.org/r/45902/#comment191199>

    This causes the ordering of `eventTypes` to matter, and appears to block forever if the
ordering is incorrect..  Is that what you want?


- Bill Farner


On April 7, 2016, 4:07 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45902/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 4:07 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> build.gradle                                                                        
   |   5 ++
>  src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
    |  94 +++++++++++++++++++++++
>  src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
| 205 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 304 insertions(+)
> 
> 
> Diffs
> -----
> 
>   build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 
>   src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45902/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq build`.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message