aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.
Date Wed, 06 Apr 2016 21:01:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45821/#review127446
-----------------------------------------------------------



Master (103dae6) is red with this patch.
  ./build-support/jenkins/build.sh

                           with temporary_dir() as checkpoint_root:
                             te = AuroraExecutor(
                     >           runner_provider=make_provider(checkpoint_root),
                                 sandbox_provider=DefaultTestSandboxProvider())
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:580:

                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:193:
in make_provider
                         pex_location=thermos_runner_path(),
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     build = True
                     
                         def thermos_runner_path(build=True):
                           if not build:
                             return getattr(thermos_runner_path, 'value', None)
                         
                           if not hasattr(thermos_runner_path, 'value'):
                             pex_dir = safe_mkdtemp()
                     >       assert subprocess.call(["./pants", "--pants-distdir=%s"
% pex_dir, "binary",
                               "src/main/python/apache/thermos/runner:thermos_runner"])
== 0
                     E       assert 1 == 0
                     E        +  where 1 = <function call at 0x7f118bb37938>(['./pants',
'--pants-distdir=/tmp/user/20000/tmp_fSutN', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
                     E        +    where <function call at 0x7f118bb37938>
= subprocess.call
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:185:
AssertionError
                     -------------- Captured stderr call --------------
                     Traceback (most recent call last):
                       File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants",
line 7, in <module>
                         from pants.bin.pants_exe import main
                     ImportError: No module named pants.bin.pants_exe
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      20 failed, 637 passed, 5 skipped, 1 warnings, 8 error in 215.34
seconds 
                     
FAILURE


               Waiting for background workers to finish.
21:01:29 04:59   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2016, 8:47 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45821/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 8:47 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This swaps out our use of the mybatis default cache with a custom one backed by Guava.
The benefit of this is that we can now plumb cache statistics out which is helpful in debugging
performance problems with MyBatis.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImpl.java PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 41519dee391a37ff4904b6c52dc276d278b85f1f

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml fd272ccf9b1cfccd9198d1e5e0db37d23f546afa

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 0219bf3da01936824154675ac812bc53cb308d3f

> 
> Diff: https://reviews.apache.org/r/45821/diff/
> 
> 
> Testing
> -------
> 
> Saw metrics in vagrant environment.
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message