aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Khutornenko <ma...@apache.org>
Subject Re: Review Request 45821: Implement custom MyBatis cache to record cache statistics.
Date Wed, 06 Apr 2016 20:40:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45821/#review127440
-----------------------------------------------------------


Ship it!




Ship It!

- Maxim Khutornenko


On April 6, 2016, 6:10 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45821/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 6:10 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This swaps out our use of the mybatis default cache with a custom one backed by Guava.
The benefit of this is that we can now plumb cache statistics out which is helpful in debugging
performance problems with MyBatis.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MyBatisCacheImpl.java PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 41519dee391a37ff4904b6c52dc276d278b85f1f

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml fd272ccf9b1cfccd9198d1e5e0db37d23f546afa

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 0219bf3da01936824154675ac812bc53cb308d3f

> 
> Diff: https://reviews.apache.org/r/45821/diff/
> 
> 
> Testing
> -------
> 
> Saw metrics in vagrant environment.
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message