aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.
Date Wed, 06 Apr 2016 19:29:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45816/#review127427
-----------------------------------------------------------




config/checkstyle/suppressions.xml (lines 24 - 25)
<https://reviews.apache.org/r/45816/#comment190720>

    Bill: I decided to stick w/ the `JavaMigrationLoader` rather than creating a new `ClasspathMigrationLoader`
this was done for two reasons:
    
    1. As I mentioned originally, I find overloading a single sql file to contain both upgrade
and downgrade scripts to be sub-optimal.
    2. It didn't seem worth carrying the extra logic for classpath loading of script files
when the logic already exists for loading classes.
    
    If you feel strongly opposed, I can revisit.


- Joshua Cohen


On April 6, 2016, 7:27 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45816/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 7:27 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1648
>     https://issues.apache.org/jira/browse/AURORA-1648
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add support for automated DB migrations and rollbacks when restoring from dbScript stored
in a snapshot.
> 
> 
> Diffs
> -----
> 
>   build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 
>   config/checkstyle/suppressions.xml 50a53e0d96cb365b2182b78769c1749b7e3558a9 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 60b66e85f83edd3c18c97e3938816cb875249d4e

>   src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 5c7d92f00ddda0a1f366ba1ca33b61829fa16ad9

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java baf460e987d0a6ba2810507695fe118b6b502f87

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 6f4e6710863a301238043edbb7bed1c7923a0720

>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationMapper.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/MigrationChangelogEntry.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 6fee2510d044515e0704cf20ec0ba77231050ec4

>   src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerIT.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V001_TestMigration.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java d93eed925d289381cdac547ad1bce749c397a07f

> 
> Diff: https://reviews.apache.org/r/45816/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> end to end tests.
> 
> Also manually verified that migrations and rollbacks are correctly performed in vagrant.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message