aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45701: Remove TaskQuery from killTasks RPC.
Date Wed, 06 Apr 2016 18:54:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45701/#review127412
-----------------------------------------------------------


Ship it!




Master (ddbb965) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 6, 2016, 6:33 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45701/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 6:33 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1591 and AURORA-1592
>     https://issues.apache.org/jira/browse/AURORA-1591
>     https://issues.apache.org/jira/browse/AURORA-1592
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This also implicitly pulled out the wildcard auth support that only existed to support
`TaskQuery`.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028

>   src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
d9039c935bb11f218558924609906b4b178711ec 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26

>   src/main/python/apache/aurora/client/api/__init__.py 18a10e224ec5ea88aee4315672ee84a4505473af

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 903121767778bf9451636bb8bae7e1c7b5af9ea8

>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
503f0c34eafb970085d98b2786c73e4d28ba8184 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
2b557e2c20127e86114f8277ae5b2954d6c4bc2e 
>   src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71

> 
> Diff: https://reviews.apache.org/r/45701/diff/
> 
> 
> Testing
> -------
> 
> Build and end-to-end tests are green.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message