aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 45721: thermos local-time
Date Tue, 05 Apr 2016 17:01:42 GMT


> On April 5, 2016, 2:17 a.m., John Sirois wrote:
> > Do you have any thoughts on why localtime should be the winner here?
> > 
> > Imagine these scenarios:
> > You're an operator for a cluster that lives 3 timezones away
> > You're an operator for 3 clusters, each in different timezones.
> > 
> > I'm not sure which is better, local time or UTC, but for non-trivial setups, UTC
is at least more neutral in general.
> > 
> > This is not a string argument one way or the other, but calling the shot on the
choice would be a good addition to the RB (and eventual commit) description IMO.
> 
> Stephan Erb wrote:
>     To make matters worse, we also have the cron timezone which defaults to `GMT` :-)

I'd prefer we stick with UTC over local time for the sake of consistency. If people feel strongly
that local time should be an option, I'd be ok with adding a flag to configure the behavior.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45721/#review127008
-----------------------------------------------------------


On April 5, 2016, 1:32 a.m., se choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45721/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 1:32 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> thermos local-time
> 
> 1. Scheduler display +09:00 (Locale timezone)
> 2. Thermos Observer display on UTC (+00:00)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/templates/main.tpl b905699897254b4a3ff6a3d03a072ac24d56e929

>   src/main/python/apache/thermos/observer/http/templates/process.tpl 4ca52bac41e638bb26c17bddee0d8946df895522

>   src/main/python/apache/thermos/observer/http/templates/task.tpl f3e06985eb3c05572aa4389d97da575b1179f616

> 
> Diff: https://reviews.apache.org/r/45721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> se choi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message