aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 45177: Setting DiscoveryInfo.
Date Tue, 05 Apr 2016 15:58:02 GMT


> On April 5, 2016, 1:39 p.m., Stephan Erb wrote:
> > docs/features/service-discovery.md, line 31
> > <https://reviews.apache.org/r/45177/diff/4/?file=1324845#file1324845line31>
> >
> >     How does Mesos DNS find out about our primary port? The code below reads like
we just populate all ports.

Performed more testing: in fact Mesos DNS merges all (ip, port) tuples into this one record.

It has another (pretty undocumented) SRV record of form `_{port-name}.{name}.{framework}.{domain}`,
which should be used for multiple ports case instead.

I'm updating document to reflect this.


> On April 5, 2016, 1:39 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java,
line 106
> > <https://reviews.apache.org/r/45177/diff/4/?file=1324847#file1324847line106>
> >
> >     Please add this flag to the `scheduler-configuration.md` documentation (we should
really automate that one day...)

Will do.


> On April 5, 2016, 1:39 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 253
> > <https://reviews.apache.org/r/45177/diff/4/?file=1324849#file1324849line253>
> >
> >     This has the disadvantage that it will ignore the portmap of the announcer.
The `mname` feature has the same problem. The portmap resolve code does currently only live
in python. https://github.com/apache/aurora/blob/b24619b28c4dbb35188871bacd0091a9e01218e3/src/main/python/apache/aurora/config/port_resolver.py#L22

> >     
> >     I don't think the limitation is very severe right now (given that this is still
a beta feature).
> >     However you should probably be aware of that. Maybe you could mention it in
the documentation.

Will mention this in document.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45177/#review126960
-----------------------------------------------------------


On April 5, 2016, 1:50 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45177/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 1:50 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar and Stephan Erb.
> 
> 
> Bugs: AURORA-1629
>     https://issues.apache.org/jira/browse/AURORA-1629
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This allows alternative service discovery methodologies to find tasks from Aurora (e.g.
mesos-dns), especially the dynamic port mapping.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779 
>   docs/features/service-discovery.md 858ca2a137db9c8fbce20e9b2b924447fe7a41ae 
>   examples/vagrant/upstart/aurora-scheduler.conf d61801c0b7c9683434a548a26bed3c49bbb75927

>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
add1270409b7e82578267a2c10cf2afe6e93e3de 
>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
7beea81a1e97f3f2fce215ff3e364919c3aebf6d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 85c550bb5754154de5f639df4a0992d10cb70993

>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 7110fbd78b1b4356acd40e5ab9c3379e5ac19df7

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 3a6048633efceec68b15d3c511237c0f1871a3fc

> 
> Diff: https://reviews.apache.org/r/45177/diff/
> 
> 
> Testing
> -------
> 
> 1. Added unit test;
> 2. Use the vagrant environment to start the example in http_example.aurora, and observe
the following in master's state.json:
> 
> ```
> curl 192.168.33.7:5050/state | jq . | less
> ....
> "tasks": [
> {
> "discovery": {
> "environment": "test",
> "name": "vagrant.test.http_example.1",
> "ports": {
> "ports": [
> {
> "name": "http",
> "number": 31648
> }
> ]
> },
> "visibility": "CLUSTER"
> },
> "executor_id": "thermos-vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
> "framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-0000",
> "id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
> "name": "vagrant/test/http_example",
> "resources": {
> "cpus": 0.4,
> "disk": 64,
> "mem": 32,
> "ports": "[31648-31648]"
> },
> ...
> ....
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message