aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 45694: Remove deprecated executor argument '-announcer-enable'
Date Mon, 04 Apr 2016 18:48:48 GMT


> On April 4, 2016, 8:38 p.m., Stephan Erb wrote:
> > RELEASE-NOTES.md, line 24
> > <https://reviews.apache.org/r/45694/diff/1/?file=1324738#file1324738line24>
> >
> >     Seems like we missed to add that to the scheduler command line documentation.
Would you mind adding it there?
> 
> Bill Farner wrote:
>     Sure thing.  I noticed that tabs are converted to spaces on master.  Unless you disagree,
i've undone that to make the doc a direct copy-paste.

Yeah totaly fine. Must have been my editor or something like that.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126894
-----------------------------------------------------------


On April 4, 2016, 8:48 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 8:48 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1606
>     https://issues.apache.org/jira/browse/AURORA-1606
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals
section.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779 
>   docs/reference/scheduler-configuration.md 9945531aeb53db7387e3b030521be94a66a0c9f0

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028

> 
> Diff: https://reviews.apache.org/r/45694/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message