aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 45177: Setting DiscoveryInfo.
Date Fri, 01 Apr 2016 16:49:32 GMT


> On March 31, 2016, 8:25 p.m., Joshua Cohen wrote:
> > RELEASE-NOTES.md, line 14
> > <https://reviews.apache.org/r/45177/diff/2/?file=1321194#file1321194line14>
> >
> >     Is there any reason we need a command line arg to control this? Is there any
detriment to just always populating `DiscoveryInfo`?
> 
> Zhitao Li wrote:
>     The only possible concern I have for now is that this would 1) generate more data
to Mesos and master/slave might have higher memory pressure, and 2) Mesos endpoints like /state.json
might be slower.
>     
>     Giving operator a flag to control this would allow people to test it out.
>     
>     Unfortunately, I don't have a large Aurora cluster running so I can't really quantifiy
it's impact right now.
> 
> Joshua Cohen wrote:
>     In my gut I feel like it shouldn't be a problem, but out of an abundance of caution,
let's go ahead with the flag. We can remove it in the future if the functionality is deemed
harmless to large clusters.

Agreed. Removing it in the future is exactly what I planned.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45177/#review126428
-----------------------------------------------------------


On March 31, 2016, 9:48 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45177/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 9:48 p.m.)
> 
> 
> Review request for Aurora, Kunal Thakar and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This allows alternative service discovery methodologies to find tasks from Aurora (e.g.
mesos-dns), especially the dynamic port mapping.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779 
>   examples/vagrant/upstart/aurora-scheduler.conf d61801c0b7c9683434a548a26bed3c49bbb75927

>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
add1270409b7e82578267a2c10cf2afe6e93e3de 
>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
7beea81a1e97f3f2fce215ff3e364919c3aebf6d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 85c550bb5754154de5f639df4a0992d10cb70993

>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 7110fbd78b1b4356acd40e5ab9c3379e5ac19df7

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 3a6048633efceec68b15d3c511237c0f1871a3fc

> 
> Diff: https://reviews.apache.org/r/45177/diff/
> 
> 
> Testing
> -------
> 
> 1. Added unit test;
> 2. Use the vagrant environment to start the example in http_example.aurora, and observe
the following in master's state.json:
> 
> ```
> curl 192.168.33.7:5050/state | jq . | less
> ....
> "tasks": [
> {
> "discovery": {
> "environment": "test",
> "name": "vagrant.test.http_example.1",
> "ports": {
> "ports": [
> {
> "name": "http",
> "number": 31648
> }
> ]
> },
> "visibility": "CLUSTER"
> },
> "executor_id": "thermos-vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
> "framework_id": "770e194c-6366-41f2-8a2d-e2c616aa9490-0000",
> "id": "vagrant-test-http_example-1-69c3908a-e8cd-44a7-a824-dd87ef5920f0",
> "name": "vagrant/test/http_example",
> "resources": {
> "cpus": 0.4,
> "disk": 64,
> "mem": 32,
> "ports": "[31648-31648]"
> },
> ...
> ....
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message