aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Staffin <ben...@gmail.com>
Subject Re: Review Request 45521: Remove client-side validation of environment names
Date Fri, 01 Apr 2016 02:06:31 GMT


> On March 31, 2016, 10 a.m., Joshua Cohen wrote:
> > Just to be sure, I saw in the IRC discussion yesterday that Bill suggested adding
the ability for scheduler-side configuration to replace this.
> > 
> > I'm a strong -1 to this client change without the accompanying scheduler change.
> 
> Bill Farner wrote:
>     I concur.  This could be as little as a regexp specified on the scheduler command
line.

we're all on the same page here - I just haven't written the scheduler half of this change
yet.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126344
-----------------------------------------------------------


On March 30, 2016, 10:55 p.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 10:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-319
>     https://issues.apache.org/jira/browse/AURORA-319
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This should be done in the scheduler, if anywhere.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e

> 
> Diff: https://reviews.apache.org/r/45521/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message