Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76E3619829 for ; Thu, 31 Mar 2016 18:22:05 +0000 (UTC) Received: (qmail 75203 invoked by uid 500); 31 Mar 2016 18:22:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75144 invoked by uid 500); 31 Mar 2016 18:22:05 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 75112 invoked by uid 99); 31 Mar 2016 18:22:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Mar 2016 18:22:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F384A2A4750; Thu, 31 Mar 2016 18:22:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3350858601379634245==" MIME-Version: 1.0 Subject: Re: Review Request 45506: Execute shell-based health checks as the task user. From: Aurora ReviewBot To: Dmitriy Shirchenko , Zameer Manji Cc: Bill Farner , Aurora ReviewBot , Aurora Date: Thu, 31 Mar 2016 18:22:02 -0000 Message-ID: <20160331182202.23781.35807@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45506/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20160331180158.23781.30973@reviews.apache.org> In-Reply-To: <20160331180158.23781.30973@reviews.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============3350858601379634245== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126387 ----------------------------------------------------------- Ship it! Master (193f17e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 31, 2016, 6:01 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45506/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 6:01 p.m.) > > > Review request for Aurora, Dmitriy Shirchenko and Zameer Manji. > > > Bugs: AURORA-1641 > https://issues.apache.org/jira/browse/AURORA-1641 > > > Repository: aurora > > > Description > ------- > > Here's a stab at this using `os` and `pwd` modules directly to demote health checks to the target user. > > > Diffs > ----- > > src/main/python/apache/aurora/common/health_check/shell.py 6cb7dfc164f4e16143fc974d50c19a5887d32015 > src/main/python/apache/aurora/executor/common/health_checker.py 28fd3ec3ef7d0b66621c0295804af0eb72c64b4a > src/test/python/apache/aurora/common/health_check/test_shell.py 7026af8c4671a40f4b517ecf12149eac34a552c8 > src/test/python/apache/aurora/executor/common/test_health_checker.py 19c4f76347e34374c29974c182d1f4c118bcb18d > > Diff: https://reviews.apache.org/r/45506/diff/ > > > Testing > ------- > > I haven't spent any time thinking of a test strategy for this, but i don't think we should proceed without end-to-end validation. I'm open to ideas here. > > > Thanks, > > Bill Farner > > --===============3350858601379634245==--