Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC9B219E29 for ; Wed, 30 Mar 2016 23:30:28 +0000 (UTC) Received: (qmail 20707 invoked by uid 500); 30 Mar 2016 23:30:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 20662 invoked by uid 500); 30 Mar 2016 23:30:28 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 20642 invoked by uid 99); 30 Mar 2016 23:30:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Mar 2016 23:30:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8077528C2E6; Wed, 30 Mar 2016 23:30:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0888965577811196584==" MIME-Version: 1.0 Subject: Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler From: Ashwin Murthy To: Bill Farner Cc: Ashwin Murthy , Aurora Date: Wed, 30 Mar 2016 23:30:26 -0000 Message-ID: <20160330233026.23781.88489@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashwin Murthy X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45511/ X-Sender: Ashwin Murthy References: <20160330231957.5121.59032@reviews.apache.org> In-Reply-To: <20160330231957.5121.59032@reviews.apache.org> X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java Reply-To: Ashwin Murthy X-ReviewRequest-Repository: aurora --===============0888965577811196584== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126223 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java (line 25) Need to fix this comment. It should be 200, 500 or 503. Will udpate in next rev - Ashwin Murthy On March 30, 2016, 11:19 p.m., Ashwin Murthy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45511/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 11:19 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > AURORA-1493: create ELB-friendly endpoint to detect leading scheduler. The fix is to add a new endpoint - "/leaderhealth" which returns http status code 200 (OK) if the instance is the leader. If the instance is not the leader but a leading exists, returns 500 (Internal server error). If there is no leader at all, returns 503 (Service unavailable) > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/45511/diff/ > > > Testing > ------- > > Added new unit test > > > Thanks, > > Ashwin Murthy > > --===============0888965577811196584==--