Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2B331850A for ; Tue, 22 Mar 2016 22:04:32 +0000 (UTC) Received: (qmail 62040 invoked by uid 500); 22 Mar 2016 22:04:32 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 61986 invoked by uid 500); 22 Mar 2016 22:04:32 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 61954 invoked by uid 99); 22 Mar 2016 22:04:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 22:04:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5562C28BC8E; Tue, 22 Mar 2016 22:04:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4521437746680935287==" MIME-Version: 1.0 Subject: Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist. From: Amol Deshmukh To: Maxim Khutornenko , Zameer Manji Cc: Joshua Cohen , Aurora ReviewBot , Amol Deshmukh , Aurora Date: Tue, 22 Mar 2016 22:04:31 -0000 Message-ID: <20160322220431.6937.70854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Amol Deshmukh X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45115/ X-Sender: Amol Deshmukh References: <20160322210452.6937.84514@reviews.apache.org> In-Reply-To: <20160322210452.6937.84514@reviews.apache.org> X-ReviewBoard-Diff-For: src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora Reply-To: Amol Deshmukh X-ReviewRequest-Repository: aurora --===============4521437746680935287== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ ----------------------------------------------------------- (Updated March 22, 2016, 3:04 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes ------- - Also applied the fix in case LoggerDestination is CONSOLE (since sys.stdout/sys.stderr are file objects). - Implemented maxim's review comments. Bugs: AURORA-1642 https://issues.apache.org/jira/browse/AURORA-1642 Repository: aurora Description ------- Ensure final processes are executed when ephemeral daemon processes exist. Diffs (updated) ----- src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7 src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5 src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc Diff: https://reviews.apache.org/r/45115/diff/ Testing ------- # End to end tests ``` $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ... *** OK (All tests passed) *** ``` # Python unit tests ``` $ ./pants test src/test/python:: ... 663 passed, 5 skipped, 1 warnings in 180.34 seconds ``` # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition: https://gist.github.com/adeshmukh/697d013dec64498a3942 Thanks, Amol Deshmukh --===============4521437746680935287==--