Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D65D18F2B for ; Tue, 22 Mar 2016 16:29:57 +0000 (UTC) Received: (qmail 76639 invoked by uid 500); 22 Mar 2016 16:29:57 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 76591 invoked by uid 500); 22 Mar 2016 16:29:57 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 76562 invoked by uid 99); 22 Mar 2016 16:29:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 16:29:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 001F128B982; Tue, 22 Mar 2016 16:29:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6039477317087123035==" MIME-Version: 1.0 Subject: Re: Review Request 45112: Add support for storing and fetching images as properties of task configs. From: Joshua Cohen To: Bill Farner , Maxim Khutornenko Cc: Joshua Cohen , Aurora , Stephan Erb , Aurora ReviewBot Date: Tue, 22 Mar 2016 16:29:55 -0000 Message-ID: <20160322162955.19594.49970@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joshua Cohen X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45112/ X-Sender: Joshua Cohen References: <20160322161801.6937.41107@reviews.apache.org> In-Reply-To: <20160322161801.6937.41107@reviews.apache.org> X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java Reply-To: Joshua Cohen X-ReviewRequest-Repository: aurora --===============6039477317087123035== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 22, 2016, 4:18 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, line 254 > > > > > > Shouldn't that rather be formulated as container != `MESOS`? As the Image field will only work together with the Mesos containerizer. In theory no one is configuring a task with a Mesos container, so it would normally be empty at this point. However, looking over the method, I can move this check down a bit and piggyback on some existing logic. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124821 ----------------------------------------------------------- On March 22, 2016, 4:25 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45112/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 4:25 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1635 > https://issues.apache.org/jira/browse/AURORA-1635 > > > Repository: aurora > > > Description > ------- > > Add support for storing and fetching images as properties of task configs. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2 > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 364026a8ef2b47cf1beafa3990691d3375516fe6 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 12ca16b79a062d9ea15c206ef963fb077ad7ad98 > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java eb848add00fba6d3571657bb9080be0599b2756a > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml fd272ccf9b1cfccd9198d1e5e0db37d23f546afa > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql be60c3be0cd51d06ba0ca7f56384281ee71d8c55 > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 1a520b3cb035a9afc25406d2f313c9f861eee4d6 > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java c316e497a34a45c7ada2ca83a1115e826c0f572f > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java e56fed2e6c0cdb47737cf1a9b637c44c5e5b9815 > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 08530397ff75081bde6f07f9d53317b5486e0da4 > > Diff: https://reviews.apache.org/r/45112/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > ran e2e tests. > > > Thanks, > > Joshua Cohen > > --===============6039477317087123035==--