Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 640AF19F18 for ; Tue, 22 Mar 2016 00:34:54 +0000 (UTC) Received: (qmail 82132 invoked by uid 500); 22 Mar 2016 00:34:54 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 82080 invoked by uid 500); 22 Mar 2016 00:34:54 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 82049 invoked by uid 99); 22 Mar 2016 00:34:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 00:34:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BF0BD28B806; Tue, 22 Mar 2016 00:34:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3769694029064983188==" MIME-Version: 1.0 Subject: Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled. From: Aurora ReviewBot To: Maxim Khutornenko , Zameer Manji Cc: Aurora , Stephan Erb , Aurora ReviewBot Date: Tue, 22 Mar 2016 00:34:48 -0000 Message-ID: <20160322003448.19594.58649@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45135/ X-Sender: Aurora ReviewBot References: <20160322001928.6937.27641@reviews.apache.org> In-Reply-To: <20160322001928.6937.27641@reviews.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============3769694029064983188== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/#review124693 ----------------------------------------------------------- Master (c5254c7) is red with this patch. ./build-support/jenkins/build.sh  proxy_driver = ProxyDriver()  with temporary_dir() as checkpoint_root:  te = AuroraExecutor( > runner_provider=make_provider(checkpoint_root),  sandbox_provider=DefaultTestSandboxProvider()) src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider  pex_location=thermos_runner_path(), _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True  def thermos_runner_path(build=True):  if not build:  return getattr(thermos_runner_path, 'value', None)    if not hasattr(thermos_runner_path, 'value'):  pex_dir = safe_mkdtemp() > assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",  "src/main/python/apache/thermos/runner:thermos_runner"]) == 0 E assert 1 == 0 E + where 1 = (['./pants', '--pants-distdir=/tmp/user/2395/tmpypgWqm', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner']) E + where = subprocess.call src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -------------- Captured stderr call -------------- Traceback (most recent call last): File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml  16 failed, 640 passed, 5 skipped, 1 warnings, 8 error in 223.31 seconds  FAILURE 00:34:43 04:33 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 22, 2016, 12:19 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45135/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 12:19 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1645 > https://issues.apache.org/jira/browse/AURORA-1645 > > > Repository: aurora > > > Description > ------- > > This allows clients to be more declarative rather than imperative > when expressing that the given job should not be scheduled. > > > Diffs > ----- > > RELEASE-NOTES.md 6e9364e34db6dbb270468db3ff333b956c6bf9f3 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d217faf44ab3d6132db3b3c4eed67effd03fb6fa > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca > > Diff: https://reviews.apache.org/r/45135/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > > --===============3769694029064983188==--