Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0D1A19CD5 for ; Mon, 21 Mar 2016 23:48:04 +0000 (UTC) Received: (qmail 70008 invoked by uid 500); 21 Mar 2016 23:48:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 69953 invoked by uid 500); 21 Mar 2016 23:48:04 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 69930 invoked by uid 99); 21 Mar 2016 23:48:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2016 23:48:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6619828B7DE; Mon, 21 Mar 2016 23:48:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2471062801200239069==" MIME-Version: 1.0 Subject: Re: Review Request 45055: Fix flickering of the Aurora logo on refresh. From: Aurora ReviewBot To: Joshua Cohen Cc: Aurora ReviewBot , Stephan Erb , Aurora Date: Mon, 21 Mar 2016 23:48:03 -0000 Message-ID: <20160321234803.6937.75777@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45055/ X-Sender: Aurora ReviewBot References: <20160321231707.6937.14069@reviews.apache.org> In-Reply-To: <20160321231707.6937.14069@reviews.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora --===============2471062801200239069== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45055/#review124685 ----------------------------------------------------------- Master (c5254c7) is red with this patch. ./build-support/jenkins/build.sh  proxy_driver = ProxyDriver()  with temporary_dir() as checkpoint_root:  te = AuroraExecutor( > runner_provider=make_provider(checkpoint_root),  sandbox_provider=DefaultTestSandboxProvider()) src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider  pex_location=thermos_runner_path(), _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True  def thermos_runner_path(build=True):  if not build:  return getattr(thermos_runner_path, 'value', None)    if not hasattr(thermos_runner_path, 'value'):  pex_dir = safe_mkdtemp() > assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",  "src/main/python/apache/thermos/runner:thermos_runner"]) == 0 E assert 1 == 0 E + where 1 = (['./pants', '--pants-distdir=/tmp/user/10021/tmpU_1x6d', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner']) E + where = subprocess.call src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -------------- Captured stderr call -------------- Traceback (most recent call last): File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml  19 failed, 637 passed, 5 skipped, 1 warnings, 8 error in 218.87 seconds  FAILURE 23:48:02 04:42 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 21, 2016, 11:17 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45055/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 11:17 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > ------- > > Refreshing a subpage of /scheduler in Chrome temporarily resize the Aurora > logo. This seems to be due to us loading the styles in the > after first rending the logo. Moving the styles to the header fixes this. > > > Diffs > ----- > > src/main/resources/scheduler/assets/scheduler/index.html 383ca43dfc14448b67181e9d94dd805ac1bbfaa7 > > Diff: https://reviews.apache.org/r/45055/diff/ > > > Testing > ------- > > > Thanks, > > Stephan Erb > > --===============2471062801200239069==--