Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============8985602466078684436=="
MIME-Version: 1.0
Subject: Re: Review Request 45115: AURORA-1642: Thermos runner finalization
 broken.
From: Amol Deshmukh <amol@apache.org>
To: Maxim Khutornenko <maxim@apache.org>, Zameer Manji <zmanji@apache.org>
Cc: Joshua Cohen <jcohen@apache.org>, Aurora ReviewBot <wfarner@apache.org>,
 Amol Deshmukh <amol@apache.org>, Aurora <reviews@aurora.apache.org>
Date: Mon, 21 Mar 2016 20:35:02 -0000
Message-ID: <20160321203502.19594.19321@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Amol Deshmukh <noreply@reviews.apache.org>
References: <20160321192830.19595.28512@reviews.apache.org>
In-Reply-To: <20160321192830.19595.28512@reviews.apache.org>
Reply-To: Amol Deshmukh <amol@apache.org>

--===============8985602466078684436==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On March 21, 2016, 12:28 p.m., Joshua Cohen wrote:
> > Does anyone think it would make sense to add a task w/ a final process to the e2e suite to avoid future breakages like this in the future?
> 
> Maxim Khutornenko wrote:
>     +1. Given how much time it took us to investigate, it would be imprudent to ship it without a good test in place. One possibility could be crafting a finalizing task into our test job. That task could just print "OK" into stderr and the test would just curl it from http://localhost:1338/logs/<task_id>/finalizing_task/0/stderr. You can get task_id from aurora_admin (see test_observer_ui for example).

Thanks for the suggestion. I will add the test and repost for review.


- Amol


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124628
-----------------------------------------------------------


On March 21, 2016, 11:36 a.m., Amol Deshmukh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 11:36 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1642
>     https://issues.apache.org/jira/browse/AURORA-1642
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1642: Fix for broken finalization in Thermos runner.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7 
>   src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5 
> 
> Diff: https://reviews.apache.org/r/45115/diff/
> 
> 
> Testing
> -------
> 
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
> 
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
>                       663 passed, 5 skipped, 1 warnings in 180.34 seconds
> 
> ```
> 
> # Also tested using a test job in vagrant to ensure that "final" processes are executed as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>


--===============8985602466078684436==--