Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E45218B2C for ; Mon, 14 Mar 2016 18:53:31 +0000 (UTC) Received: (qmail 58414 invoked by uid 500); 14 Mar 2016 18:53:31 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 58360 invoked by uid 500); 14 Mar 2016 18:53:31 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 58341 invoked by uid 99); 14 Mar 2016 18:53:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Mar 2016 18:53:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4086B2ABB4F; Mon, 14 Mar 2016 18:53:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5258887741494800909==" MIME-Version: 1.0 Subject: Review Request 44799: Fixup rpm builder and test docs. From: John Sirois To: Bill Farner Cc: Aurora , John Sirois Date: Mon, 14 Mar 2016 18:53:29 -0000 Message-ID: <20160314185329.26510.31763@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44799/ X-Sender: John Sirois Reply-To: John Sirois X-ReviewRequest-Repository: aurora-packaging --===============5258887741494800909== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44799/ ----------------------------------------------------------- Review request for Aurora and Bill Farner. Repository: aurora-packaging Description ------- This adjusts to fallout from https://reviews.apache.org/r/43936/ to get the centos-7 builder working again and improves the test docs to include both locally built rpm and released (or release candidate) rpm testing. This change also imporves the `release-candidate` script to be idempotent and handle missing binaries (ie: when only using a subset of builders). build-support/release/release-candidate | 33 +++++++++++++++++++++------------ specs/rpm/Makefile | 5 ++--- specs/rpm/aurora.spec | 2 +- test/rpm/centos-7/README.md | 24 +++++++++++++++++++++--- 4 files changed, 45 insertions(+), 19 deletions(-) Diffs ----- build-support/release/release-candidate c21a0107043c76137daace8823dd28ac3c46957d specs/rpm/Makefile 0fa215854df9678adf7f9a1209dfca1cc4db8ce9 specs/rpm/aurora.spec 20a6d349eb7cd6c801ddc7b149dd656f4a517cd1 test/rpm/centos-7/README.md 6a6e419eae0b91608450d932139e515ff47c8445 Diff: https://reviews.apache.org/r/44799/diff/ Testing ------- CentOS 7 test doc fixes rendered here: https://github.com/jsirois/aurora-packaging/tree/0.12.x/test/rpm/centos-7 I exercised the `Makefile` and `aurora.spec` fixes to build a new batch of rpms and then used the improved `release-candidate` script to create the rpm `upload.tar` and update the 0.12.0 RC bintray repo here: https://bintray.com/john-sirois/aurora/centos-7/0.12.0 Thanks, John Sirois --===============5258887741494800909==--