Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C699C18B7F for ; Thu, 10 Mar 2016 19:42:09 +0000 (UTC) Received: (qmail 25298 invoked by uid 500); 10 Mar 2016 19:42:09 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 25247 invoked by uid 500); 10 Mar 2016 19:42:09 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 25217 invoked by uid 99); 10 Mar 2016 19:42:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2016 19:42:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4DCAF2AB099; Thu, 10 Mar 2016 19:42:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2124872612563189174==" MIME-Version: 1.0 Subject: Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support From: Maxim Khutornenko To: Bill Farner , Steve Niemitz Cc: Joshua Cohen , Aurora , Maxim Khutornenko , Stephan Erb , Aurora ReviewBot Date: Thu, 10 Mar 2016 19:42:08 -0000 Message-ID: <20160310194208.28153.91852@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Maxim Khutornenko X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44602/ X-Sender: Maxim Khutornenko References: <20160310185643.28009.6006@reviews.apache.org> In-Reply-To: <20160310185643.28009.6006@reviews.apache.org> Reply-To: Maxim Khutornenko X-ReviewRequest-Repository: aurora --===============2124872612563189174== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 10, 2016, 6:56 p.m., Joshua Cohen wrote: > > docs/deploying-aurora-scheduler.md, lines 289-291 > > > > > > I think this "only" is misleading here? If I understand correctly, a task, `devcluster/www-data/prod/hello` with a dedicated constraint of `*/web.multi` could be scheduled on an agent that has a dedicated attribute of *either* `*/web.multi` or `www-data/web.multi`, correct? Not really. Task constraint value must match mesos attribute value exactly. The `*` is used to remove the role match requirement but does not go as far as having a regex-like meaning you are suggesting. That would require making `AttributeFilter` syntax sensitive. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/#review122959 ----------------------------------------------------------- On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44602/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 6:44 p.m.) > > > Review request for Aurora, Steve Niemitz and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562. > > > Diffs > ----- > > NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb > docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0 > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d > > Diff: https://reviews.apache.org/r/44602/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============2124872612563189174==--