Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0953519C1E for ; Tue, 8 Mar 2016 02:21:22 +0000 (UTC) Received: (qmail 76855 invoked by uid 500); 8 Mar 2016 02:21:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 76796 invoked by uid 500); 8 Mar 2016 02:21:21 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 76758 invoked by uid 99); 8 Mar 2016 02:21:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Mar 2016 02:21:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 68DFD2E8C73; Tue, 8 Mar 2016 02:21:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1387323767868869823==" MIME-Version: 1.0 Subject: Review Request 44493: Log and terminate scheduler on updater thread failure. From: Maxim Khutornenko To: Bill Farner , John Sirois Cc: Aurora , Maxim Khutornenko Date: Tue, 08 Mar 2016 02:21:20 -0000 Message-ID: <20160308022120.8639.1535@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Maxim Khutornenko X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44493/ X-Sender: Maxim Khutornenko Reply-To: Maxim Khutornenko X-ReviewRequest-Repository: aurora --===============1387323767868869823== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44493/ ----------------------------------------------------------- Review request for Aurora, John Sirois and Bill Farner. Bugs: AURORA-1630 https://issues.apache.org/jira/browse/AURORA-1630 Repository: aurora Description ------- Moved HistoryPruner Runnable handler into AsyncUtil to reuse in updater. Diffs ----- src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 80dc35ece876d46c8b94540cd6ab19092854867e src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 22753b4579dfdaa1fceea2e095ba7063143959c6 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 48d7e2afb795a743ca9ca3e125a02195e45f1f67 src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java c0472d732874dba5cd3534b07301432fed04fcca src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java b39e38883a0e57210596d5c71ec5c90234837296 Diff: https://reviews.apache.org/r/44493/diff/ Testing ------- ./gradlew -Pq build Thanks, Maxim Khutornenko --===============1387323767868869823==--