Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0FB9B199E2 for ; Tue, 8 Mar 2016 01:22:23 +0000 (UTC) Received: (qmail 9600 invoked by uid 500); 8 Mar 2016 01:22:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 9547 invoked by uid 500); 8 Mar 2016 01:22:23 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 9519 invoked by uid 99); 8 Mar 2016 01:22:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Mar 2016 01:22:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB0C92E8BE1; Tue, 8 Mar 2016 01:22:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1806341677932066622==" MIME-Version: 1.0 Subject: Re: Review Request 44486: export environment variables into the shellchecker command From: Bill Farner To: Bill Farner , John Sirois , Zameer Manji Cc: Dmitriy Shirchenko , Aurora Date: Tue, 08 Mar 2016 01:22:21 -0000 Message-ID: <20160308012221.8639.54354@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44486/ X-Sender: Bill Farner X-ReviewBoard-ShipIt: 1 References: <20160308004951.8639.29954@reviews.apache.org> In-Reply-To: <20160308004951.8639.29954@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Bill Farner X-ReviewRequest-Repository: aurora --===============1806341677932066622== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122448 ----------------------------------------------------------- Ship it! Ship It! - Bill Farner On March 7, 2016, 4:49 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 4:49 p.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > ------- > > export environment variables into the shellchecker command > > > Diffs > ----- > > src/main/python/apache/aurora/common/health_check/shell.py 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > ------- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > > --===============1806341677932066622==--