aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <>
Subject Re: Review Request 45506: Execute shell-based health checks as the task user.
Date Thu, 31 Mar 2016 20:18:32 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 31, 2016, 1:18 p.m.)

Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.

Bugs: AURORA-1641

Repository: aurora


Here's a stab at this using `os` and `pwd` modules directly to demote health checks to the
target user.

Diffs (updated)

  src/main/python/apache/aurora/common/health_check/ 6cb7dfc164f4e16143fc974d50c19a5887d32015

  src/main/python/apache/aurora/executor/common/ 28fd3ec3ef7d0b66621c0295804af0eb72c64b4a

  src/test/python/apache/aurora/common/health_check/ 7026af8c4671a40f4b517ecf12149eac34a552c8

  src/test/python/apache/aurora/executor/common/ 19c4f76347e34374c29974c182d1f4c118bcb18d

  src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora c709b035a54822ff700136963e2f942f30f38898

  src/test/sh/org/apache/aurora/e2e/ e1c12bbd4382c31e576439f6693d82d5661029b9



Altered an end-to-end test case to verify that shell checks are not run as a privileged user.


Bill Farner

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message