aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45456: Use correct query to serve /maintenance.
Date Wed, 30 Mar 2016 03:26:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126028
-----------------------------------------------------------



Master (ec29ac1) is red with this patch.
  ./build-support/jenkins/build.sh

                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
                         
                           assert hct._total_latency == 0
                           assert hct.metrics.sample()['total_latency_secs'] == 0
                         
                           # start the health check (during health check it is still 0)
                           epsilon = 0.001
                           self._clock.tick(1.0 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
                           assert hct._total_latency == 0
                           assert hct.metrics.sample()['total_latency_secs'] == 0
                           assert hct.metrics.sample()['checks'] == 0
                         
                           # finish the health check
                           self._clock.tick(0.5 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 # interval_secs
                     >     assert hct._total_latency == 0.5
                     E     AssertionError: assert 0.5009999999999999 == 0.5
                     E      +  where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker
object at 0x7feb68a6cf90>._total_latency
                     
                     src/test/python/apache/aurora/executor/common/test_health_checker.py:174:
AssertionError
                     -------------- Captured stderr call --------------
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 1.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 1.501
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>]
Time now: 1.502
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 663 passed, 5 skipped, 1 warnings in 208.34 seconds

                     
FAILURE


03:17:59 04:24   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 29, 2016, 10:46 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 10:46 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1652
>     https://issues.apache.org/jira/browse/AURORA-1652
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixes the 2 issues identified in AURORA-1652.
> 
> I will submit a separate patch to mitigate this issue by preventing error-prone calls
to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect
of not filtering).
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd

>   src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45456/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message