aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kunal Thakar <>
Subject Re: Review Request 45042: Add ACL support for announcer
Date Wed, 30 Mar 2016 00:17:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 30, 2016, 12:17 a.m.)

Review request for Aurora, Bill Farner and Zameer Manji.


Pystachio'ed the config for easier validation/conversion, removed new e2e test and added auth
to main e2e test

Repository: aurora


Add ACL support for announcer

Adding support for service discovery ZK authentication. ZK authentication secrets should be
stored in a file as json (as follows):
(Updated JSON format for config file)
  "auth": [
      "scheme": "<scheme>",
      "credential": "<plain_credential>"
  "acls": [
      "scheme": "<scheme>",
      "credential": "<encrypted_credential>",
      "permissions": {
        "read": <bool>,
        "write": <bool>,
        "create": <bool>,
        "delete": <bool>,
        "admin": <bool>,
        "all": <bool>

Diffs (updated)
----- 34f28a165aae4ae24fa95ef19b4972e088fd63a0 
  docs/operations/ 1a3d9b7e7ba4ec1952dc886d5fbeb6b85d994fb9 
  examples/vagrant/announcer-auth.json PRE-CREATION 
  examples/vagrant/upstart/aurora-scheduler.conf 120b89a1dc10a259940cb9527eb2517f19d04471

  src/main/python/apache/aurora/executor/bin/ 6634506108c346f8c23b2da7cc8d20d09d07d590

  src/main/python/apache/aurora/executor/common/ 79a9cfb6ac3a8444f09fb3658e6e859e06941ba4

  src/main/python/apache/aurora/executor/common/ PRE-CREATION 
  src/test/python/apache/aurora/executor/bin/ e9f7851292aef3a36da5da9b0fc333a7e7750cf3

  src/test/python/apache/aurora/executor/common/ 142b58d5e577c9f4b8e2ae8473cffdea94eba21f

  src/test/sh/org/apache/aurora/e2e/ fca1137bd2e7b1306a03dc2a54d2ef15b59af6a8





Kunal Thakar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message