aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kunal Thakar <kun...@gmail.com>
Subject Re: Review Request 45042: Add ACL support for announcer
Date Wed, 30 Mar 2016 00:17:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45042/
-----------------------------------------------------------

(Updated March 30, 2016, 12:17 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
-------

Pystachio'ed the config for easier validation/conversion, removed new e2e test and added auth
to main e2e test


Repository: aurora


Description
-------

Add ACL support for announcer
https://issues.apache.org/jira/browse/AURORA-1643

Adding support for service discovery ZK authentication. ZK authentication secrets should be
stored in a file as json (as follows):
(Updated JSON format for config file)
```json
{
  "auth": [
    {
      "scheme": "<scheme>",
      "credential": "<plain_credential>"
    }
  ],
  "acls": [
    {
      "scheme": "<scheme>",
      "credential": "<encrypted_credential>",
      "permissions": {
        "read": <bool>,
        "write": <bool>,
        "create": <bool>,
        "delete": <bool>,
        "admin": <bool>,
        "all": <bool>
      }
    }
  ]
}
```


Diffs (updated)
-----

  RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 
  docs/operations/security.md 1a3d9b7e7ba4ec1952dc886d5fbeb6b85d994fb9 
  examples/vagrant/announcer-auth.json PRE-CREATION 
  examples/vagrant/upstart/aurora-scheduler.conf 120b89a1dc10a259940cb9527eb2517f19d04471

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 6634506108c346f8c23b2da7cc8d20d09d07d590

  src/main/python/apache/aurora/executor/common/announcer.py 79a9cfb6ac3a8444f09fb3658e6e859e06941ba4

  src/main/python/apache/aurora/executor/common/announcer_zkauth_schema.py PRE-CREATION 
  src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py e9f7851292aef3a36da5da9b0fc333a7e7750cf3

  src/test/python/apache/aurora/executor/common/test_announcer.py 142b58d5e577c9f4b8e2ae8473cffdea94eba21f

  src/test/sh/org/apache/aurora/e2e/validate_serverset.py fca1137bd2e7b1306a03dc2a54d2ef15b59af6a8


Diff: https://reviews.apache.org/r/45042/diff/


Testing
-------

/vagrant/src/test/sh/org/apache/aurora/e2e/test_announcer_auth_end_to_end.sh
/vagrant/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Kunal Thakar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message