aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Review Request 45456: Use correct query to serve /maintenance.
Date Tue, 29 Mar 2016 22:46:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/
-----------------------------------------------------------

Review request for Aurora, John Sirois and Zameer Manji.


Bugs: AURORA-1652
    https://issues.apache.org/jira/browse/AURORA-1652


Repository: aurora


Description
-------

Fixes the 2 issues identified in AURORA-1652.

I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences
like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).


Diffs
-----

  config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727 
  src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd

  src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/45456/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message