aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45366: Eliminate I* isSet methods for collection fields.
Date Sun, 27 Mar 2016 23:37:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125582
-----------------------------------------------------------



Master (b352e8b) is red with this patch.
  ./build-support/jenkins/build.sh

                           self._clock.tick(0.5 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 # interval_secs
                           assert hct._total_latency == 0.5
                           assert hct.metrics.sample()['total_latency_secs'] == 0.5
                           assert hct.metrics.sample()['checks'] == 1
                         
                           # tick again
                           self._clock.tick(1.0 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.tick(0.5 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 # interval_secs
                     >     assert hct._total_latency == 1.0
                     E     AssertionError: assert 1.001 == 1.0
                     E      +  where 1.001 = <apache.aurora.executor.common.health_checker.HealthChecker
object at 0x7f40aed369d0>._total_latency
                     
                     src/test/python/apache/aurora/executor/common/test_health_checker.py:184:
AssertionError
                     -------------- Captured stderr call --------------
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 1.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 1.501
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 1.502
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 1.502
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 2.502
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 2.503
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 2.503
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 3.003
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f40aed36e10>]
Time now: 3.004
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 663 passed, 5 skipped, 1 warnings in 291.87 seconds

                     
FAILURE


23:37:28 06:38   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 27, 2016, 10:39 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
> 
> (Updated March 27, 2016, 10:39 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1650
>     https://issues.apache.org/jira/browse/AURORA-1650
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> These methods always returned `true`, which was misleading.  Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
> 
>  src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java |
3 +--
>  src/main/java/org/apache/aurora/scheduler/http/Mname.java                         |
4 +---
>  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java             |
4 +---
>  src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java    |
2 +-
>  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java        |
1 -
>  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py                |
2 +-
>  6 files changed, 5 insertions(+), 11 deletions(-)
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b3b8ccf868c2a2f18f720a837e90d763072dd3eb

>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 807a1989473f1a933790e5837d804941419007a3

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 20cbd419dcb988f2c7ba72c8acbe6fee90d02248

>   src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 4b0ef81e5dd2723291a9810980246c6c3e7924f5

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 69010985aa066ebb6686f256a734d77e008ccd1a

>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py e9e9368328992cb8cc26eb22d86aa244d5fa9250

> 
> Diff: https://reviews.apache.org/r/45366/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message