aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45330: Remove unnecessary Map workarounds in mybatis mappers.
Date Fri, 25 Mar 2016 05:41:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45330/#review125391
-----------------------------------------------------------



Master (9927231) is red with this patch.
  ./build-support/jenkins/build.sh

                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
                         
                           assert hct._total_latency == 0
                           assert hct.metrics.sample()['total_latency_secs'] == 0
                         
                           # start the health check (during health check it is still 0)
                           epsilon = 0.001
                           self._clock.tick(1.0 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
                           assert hct._total_latency == 0
                           assert hct.metrics.sample()['total_latency_secs'] == 0
                           assert hct.metrics.sample()['checks'] == 0
                         
                           # finish the health check
                           self._clock.tick(0.5 + epsilon)
                           self._clock.converge(threads=[hct.threaded_health_checker])
                           self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
 # interval_secs
                     >     assert hct._total_latency == 0.5
                     E     AssertionError: assert 0.5009999999999999 == 0.5
                     E      +  where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker
object at 0x7f8700539a10>._total_latency
                     
                     src/test/python/apache/aurora/executor/common/test_health_checker.py:174:
AssertionError
                     -------------- Captured stderr call --------------
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 1.0
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 1.501
                     [<twitter.common.testing.clock.ThreadedClock object at 0x7f8700539d50>]
Time now: 1.502
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 663 passed, 5 skipped, 1 warnings in 210.54 seconds

                     
FAILURE


05:33:28 04:45   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 25, 2016, 4:43 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45330/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 4:43 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I realized that on _insert_, we can iterate over `Map`s just fine (without the conversion
to `List<Pair<?, ?>`, which allows us to remove some code.  Unfortunately i do not
yet know of an approach to remove the workaround when querying.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 078dd8b63fdca192c735f9097edd030ee315a021

>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 364026a8ef2b47cf1beafa3990691d3375516fe6

>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 12ca16b79a062d9ea15c206ef963fb077ad7ad98

>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java 4bf40047e105389ac7139edc449857889d390106

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java fdfff774e13f3e5f5e2c08f4692bc61427f2cbaf

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java cbc6a0c6085287f8065f182c24f79e47812af498

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java eb848add00fba6d3571657bb9080be0599b2756a

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java 922578f0e545de67cfd26a601af29f00882a2a09

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml fd272ccf9b1cfccd9198d1e5e0db37d23f546afa

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 684614ffc42dd6778c7675a6c2f81cb72c106c0e

> 
> Diff: https://reviews.apache.org/r/45330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message