aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 45193: Treat empty and null collections equivalently in task queries.
Date Wed, 23 Mar 2016 02:32:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45193/
-----------------------------------------------------------

(Updated March 22, 2016, 8:32 p.m.)


Review request for Aurora, David Chung, Bill Farner, and Zameer Manji.


Repository: aurora


Description (updated)
-------

Previously, `null` was handled differently from an empty collection in
task queries. For the Go thrift bindings, this was problematic since
zero values in Go are useful in almost all cases and in particular in the
case of slices (collections).  In these cases unset `TaskQuery`
collection parameters are represented as empty collections (empty
slices[]) instead of `nil` (`null`), leading to the inability to use the
query API in any natural way.

 src/main/java/org/apache/aurora/scheduler/base/JobKeys.java                  |  2 +-
 src/main/java/org/apache/aurora/scheduler/base/Query.java                    |  2 +-
 src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java             |  2 +-
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java      |  6 ++++--
 src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml     |  6 +++---
 src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java | 20 +++++++++++++++++---
 6 files changed, 27 insertions(+), 11 deletions(-)


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 8f5bf58b963ae5f76aad7dfa34bae5b9e67d6242

  src/main/java/org/apache/aurora/scheduler/base/Query.java ee01eaa4d0230d6bf0909b6460f27a74f03240db

  src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java ac0bb374842741d7ccb7a83c574a90ac156af0f9

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 231a55615abfbb483667f5f8ef71d2709fc16a88

  src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 684614ffc42dd6778c7675a6c2f81cb72c106c0e

  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java e56fed2e6c0cdb47737cf1a9b637c44c5e5b9815


Diff: https://reviews.apache.org/r/45193/diff/


Testing
-------

NB: This change was broken out of https://reviews.apache.org/r/42756/
since it stands on its own (although its slightly more awkward in the
mutable thrift world) and the case of the Go Aurora API client forces the
issue.

Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message