aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 45115: Ensure final processes are executed when ephemeral daemon processes exist.
Date Tue, 22 Mar 2016 21:58:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124899
-----------------------------------------------------------



Master (b5c9e1b) is red with this patch.
  ./build-support/jenkins/build.sh

                           proxy_driver = ProxyDriver()
                           with temporary_dir() as checkpoint_root:
                             te = AuroraExecutor(
                     >           runner_provider=make_provider(checkpoint_root),
                                 sandbox_provider=DefaultTestSandboxProvider())
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:580:

                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:193:
in make_provider
                         pex_location=thermos_runner_path(),
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     build = True
                     
                         def thermos_runner_path(build=True):
                           if not build:
                             return getattr(thermos_runner_path, 'value', None)
                         
                           if not hasattr(thermos_runner_path, 'value'):
                             pex_dir = safe_mkdtemp()
                     >       assert subprocess.call(["./pants", "--pants-distdir=%s"
% pex_dir, "binary",
                               "src/main/python/apache/thermos/runner:thermos_runner"])
== 0
                     E       assert 1 == 0
                     E        +  where 1 = <function call at 0x7fb45014a938>(['./pants',
'--pants-distdir=/tmp/user/2396/tmpe7EGxb', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
                     E        +    where <function call at 0x7fb45014a938>
= subprocess.call
                     
                     src/test/python/apache/aurora/executor/test_thermos_executor.py:185:
AssertionError
                     -------------- Captured stderr call --------------
                     Traceback (most recent call last):
                       File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants",
line 7, in <module>
                         from pants.bin.pants_exe import main
                     ImportError: No module named pants.bin.pants_exe
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      16 failed, 640 passed, 5 skipped, 1 warnings, 8 error in 178.00
seconds 
                     
FAILURE


21:50:31 04:00   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 22, 2016, 9:04 p.m., Amol Deshmukh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45115/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 9:04 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1642
>     https://issues.apache.org/jira/browse/AURORA-1642
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ensure final processes are executed when ephemeral daemon processes exist.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/core/process.py f147af7d0e84309691c135c8057a597379fa83e7

>   src/test/python/apache/thermos/core/test_process.py c339c91eb24616c8d640877ef088f659523d2bf5

>   src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc

> 
> Diff: https://reviews.apache.org/r/45115/diff/
> 
> 
> Testing
> -------
> 
> # End to end tests
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> *** OK (All tests passed) ***
> ```
> 
> # Python unit tests
> ```
> $ ./pants test src/test/python::
> ...
>                       663 passed, 5 skipped, 1 warnings in 180.34 seconds
> 
> ```
> 
> # Also tested using a test job in vagrant to ensure that "final" processes are executed
as expected using this job definition:
> https://gist.github.com/adeshmukh/697d013dec64498a3942
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message